-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checklist Editor for Heimdall #3315
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 3 alerts when merging fc051a8 into eee1cb1 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging a6a2f79 into eee1cb1 - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 77ec2cb into 57f603f - view on LGTM.com new alerts:
|
This pull request introduces 4 alerts when merging 4ad6979 into 57f603f - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging ede31f4 into b394c65 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging d11ca35 into d27d295 - view on LGTM.com new alerts:
|
This pull request has a conflict. Could you fix it @Rlin232? |
This pull request introduces 1 alert when merging c487e1e into a47500a - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 10d5773 into a47500a - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging e5a69d3 into a47500a - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 5e597f1 into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 04d2d0a into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 026733b into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging d4c9e5a into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f5299cd into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging c4c4ccf into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging a1a70d2 into b5ee02f - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging b91e7b1 into 06ac9f3 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 1c9cd79 into 75e076a - view on LGTM.com new alerts:
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Are future features going to include:
|
@ejaronne Can you make the first bullet point a new issue? W/r to the second one, there's definitely issues with the hdf2ckl mappers that I haven't had an opportunity to fix. |
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
daa16e3
to
6e45649
Compare
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
…rol enhancements or control statements Signed-off-by: Joyce Quach <[email protected]>
8a11661
to
7b3d6b3
Compare
This pull request has a conflict. Could you fix it @Rlin232? |
2874ea6
to
1718abe
Compare
1718abe
to
ba8a6af
Compare
f7ddc60
to
a255665
Compare
This pull request has a conflict. Could you fix it @Rlin232? |
e43daee
to
5c26f5e
Compare
3332884
to
5a5035b
Compare
Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
…sizeable since footer cuts off the Comments textarea Signed-off-by: Joyce Quach <[email protected]>
a1c0ea5
to
f108b18
Compare
…f gap to right of table and there being too many divs Signed-off-by: Joyce Quach <[email protected]>
Signed-off-by: Joyce Quach <[email protected]>
Quality Gate failedFailed conditions See analysis details on SonarQube Cloud Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE |
UI/UX:
Improve filtering (Completed in checklistView-Filtering):
Fix These
When the Results, Profiles, or Checklist folding group is click, it opens the Panel (displays the Heimdall for the selected group) this is not the expected behavior - expect the group panel to open.
Update the
Quick Filters
(I would change the name toCommon Filter Options
and center the title) to be more informative that the filters belong to all types of scans (Results, Profiles, and Checklists) - Make a border around the panel to distinguished that the filter is common to all group selections.When opening the Checklist panel the two panels displayed are not aligned top.
When opening the Checklist panel nothing is displayed until you click on the
Short ID
slider (see image above).Make the
Rules
display panel high to match the Heimdall main frame (minus some padding for good aesthetics)Ensure that the horizontal scrollbar is displayed after fixing the vertical high an scrolling
Unable to read bottom potion of the STIG control
No STIG information is displayed (STIG ID, Bule ID, Group Name, etc)
Visual bug with filtering rules by keywords logic - adding two filters whose filter "keyword" is the same but each is an inclusive filter and an exclusive filter. Selecting one of the filters to remove results in both being selected, but only the "truly" selected filter is removed. Attempting to click "Remove filter" with the remaining formerly-duplicate-word filter does not work, as if it were not "truly" selected. Deselecting one of the two "duplicates" deselects both "duplicates". In STIGViewer 2.18, adding an exclusive filter and attempting to add an inclusive filter (or vice versa) with the same keyword is not allowed. In Vue, this causes a warning:
hook.js:608 [Vue warn]: Duplicate keys detected: '<duplicate string>'. This may cause an update error.
Bug with filtering rules by keywords logic - Not selecting a filter property in either the Checklist Filters or Category Filters uses a default filter property of "keywords", even though "keywords" is not selectable in Checklist Filters. However, the search bar will show a
key:value
comma-separated string indicating that the key is missing if the filter property wasn't selected.ChecklistSeverityOverride.vue - gets
found in
when selecting a severity override different from default on first load of a control
happens when you pick a severity override that is equal to the default (after you select a severity override at first that is different from the default) AND under Misc Data, the
Severity Override Justification:
does not reset when you select the default severity override.The Clear Selection button's text disappears when the window width is 959 px.
Tests:
Other Improvements
Move To Separate PR
Support "Must match: All" filter matching from STIGViewer 2.18. Having more than 1 exclusive filter on Category Filters > Filter Properties breaks both exclusive filters. e.g. Keyword
366
, Filtercci
and Keyword68
, Filtercci
results in the list of rules now containing those whose CCIs have366
and68
. If there is only 1 exclusive filter in the list, then it works again. In the STIGViewer 2.18, the same filtering logic is found when selecting the "Must match: Any" option, but not in the "Must match: All" option.